Skip to content

Enhanced node components with improved shadow effects for better visual depth #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnpotters1 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Enhanced node components with improved shadow effects for better visual depth #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/frontend/app/routes/studio/canvas/nodetypes/child-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
// Add child recursively
addChildToChild(rootId, child.id, newChild)
},
[

Check warning on line 139 in src/main/frontend/app/routes/studio/canvas/nodetypes/child-node.tsx

View workflow job for this annotation

GitHub Actions / Build & Run All Tests 

React Hook useCallback has missing dependencies: 'setAttributes' and 'setNodeId'. Either include them or remove the dependency array
setDraggedName,
canAcceptChild,
showNodeContextMenu,
Expand All @@ -159,7 +159,7 @@
<div
data-childnode-id={child.id}
className={clsx(
'bg-background relative mr-0.5 mb-2 rounded-md border',
'bg-background relative mr-0.5 mb-2 rounded-md border shadow-[3px_3px_6px_rgba(0,0,0,0.12)]',
isSelected && 'border-1',
!isSelected && dragForbidden && 'border-2 border-dashed',
!isSelected && !dragForbidden && 'border-border',
Expand Down Expand Up @@ -197,7 +197,7 @@
</div>

{/* Body */}
<div className="child-node-body relative min-h-25 px-1 py-1">
<div className="child-node-body relative min-h-25 rounded-b-md px-1 py-1 shadow-[inset_0px_3px_5px_rgba(0,0,0,0.08),inset_3px_0px_4px_rgba(0,0,0,0.05),inset_-3px_0px_4px_rgba(0,0,0,0.05)]">
{child.attributes &&
Object.entries(child.attributes).map(([key, value]) => (
<div key={key} className="my-1">
Expand Down
2 changes: 1 addition & 1 deletion src/main/frontend/app/routes/studio/canvas/nodetypes/exit-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function ExitNodeComponent(properties: NodeProps<ExitNode>) {
<ResizeIcon />
</NodeResizeControl>
<div
className={`bg-background flex h-full w-full flex-col items-center rounded-md border ${
className={`bg-background flex h-full w-full flex-col items-center rounded-md border shadow-[3px_3px_8px_rgba(0,0,0,0.15)] ${
properties.selected ? 'border-blue-500' : 'border-border'
}`}
style={{
Expand Down
4 changes: 2 additions & 2 deletions src/main/frontend/app/routes/studio/canvas/nodetypes/frank-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@

addChild(properties.id, child)
},
[

Check warning on line 345 in src/main/frontend/app/routes/studio/canvas/nodetypes/frank-node.tsx

View workflow job for this annotation

GitHub Actions / Build & Run All Tests 

React Hook useCallback has missing dependencies: 'setAttributes' and 'setNodeId'. Either include them or remove the dependency array
properties.id,
addChild,
setIsNewNode,
Expand Down Expand Up @@ -474,7 +474,7 @@
<ResizeIcon />
</NodeResizeControl>
<div
className={`bg-background border-border relative flex w-full flex-col items-center overflow-x-visible rounded-md border ${isManuallyResized ? 'h-full overflow-y-hidden' : 'overflow-y-visible'}`}
className={`bg-background border-border relative flex w-full flex-col items-center overflow-x-visible rounded-md border shadow-[3px_3px_8px_rgba(0,0,0,0.15)] ${isManuallyResized ? 'h-full overflow-y-hidden' : 'overflow-y-visible'}`}
style={{
minWidth: `${minNodeWidth}px`,
...(properties.selected && { borderColor: `var(${colorVariable})` }),
Expand Down Expand Up @@ -529,7 +529,7 @@
))}
{(properties.data.children.length > 0 || dragOver || canDropDraggedElement) && (
<div className="w-full p-4">
<div className="border-border bg-background w-full rounded-md p-4 shadow-[inset_0px_2px_4px_rgba(0,0,0,0.1)]">
<div className="border-border bg-background w-full rounded-md p-4 shadow-[inset_0px_3px_6px_rgba(0,0,0,0.12),inset_3px_0px_5px_rgba(0,0,0,0.07),inset_-3px_0px_5px_rgba(0,0,0,0.07)]">
{properties.data.children.map((child) => (
<div key={child.id} data-child-id={child.id} className="child-drop-zone">
<ChildNodeComponent
Expand Down
Loading