Skip to content

fix: show the accounting nudge on the Accounting workspace (backport #1265) - #1266

Open
mergify[bot] wants to merge 2 commits into
version-3-hotfixfrom
mergify/bp/version-3-hotfix/pr-1265
Open

fix: show the accounting nudge on the Accounting workspace (backport #1265)#1266
mergify[bot] wants to merge 2 commits into
version-3-hotfixfrom
mergify/bp/version-3-hotfix/pr-1265

Conversation

@mergify

@mergify mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The nudge banner never showed for the accounting template. The desk opens a workspace at the first item in its sidebar, and Financial Reports starts at the Balance Sheet report instead of a link back to itself, so its workspace page is unreachable.

Nudge from Accounting too, and key the dismissal on the template so one dismissal covers both. Old dismissal keys are orphaned, so a user who dismissed the banner sees it one more time.

Tested on a site with erpnext and insights.


This is an automatic backport of pull request #1265 done by Mergify.

(cherry picked from commit 1a78fa6)

# Conflicts:
#	insights/public/js/insights_nudge.bundle.js
@mergify mergify Bot added the conflicts label Jul 30, 2026
@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 1a78fa6 has failed:

On branch mergify/bp/version-3-hotfix/pr-1265
Your branch is up to date with 'origin/version-3-hotfix'.

You are currently cherry-picking commit 1a78fa66.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   insights/public/js/insights_nudge.bundle.js

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.28%. Comparing base (83bcccf) to head (f1972b0).
⚠️ Report is 72 commits behind head on version-3-hotfix.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           version-3-hotfix    #1266      +/-   ##
====================================================
+ Coverage             47.91%   48.28%   +0.37%     
====================================================
  Files                    76       76              
  Lines                  5998     6020      +22     
====================================================
+ Hits                   2874     2907      +33     
+ Misses                 3124     3113      -11     
Flag Coverage Δ
server 48.28% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants