fix: show the accounting nudge on the Accounting workspace (backport #1265) - #1266
Open
mergify[bot] wants to merge 2 commits into
Open
fix: show the accounting nudge on the Accounting workspace (backport #1265)#1266mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
(cherry picked from commit 1a78fa6) # Conflicts: # insights/public/js/insights_nudge.bundle.js
Contributor
Author
|
Cherry-pick of 1a78fa6 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version-3-hotfix #1266 +/- ##
====================================================
+ Coverage 47.91% 48.28% +0.37%
====================================================
Files 76 76
Lines 5998 6020 +22
====================================================
+ Hits 2874 2907 +33
+ Misses 3124 3113 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nudge banner never showed for the accounting template. The desk opens a workspace at the first item in its sidebar, and
Financial Reportsstarts at the Balance Sheet report instead of a link back to itself, so its workspace page is unreachable.Nudge from
Accountingtoo, and key the dismissal on the template so one dismissal covers both. Old dismissal keys are orphaned, so a user who dismissed the banner sees it one more time.Tested on a site with erpnext and insights.
This is an automatic backport of pull request #1265 done by Mergify.