Skip to content

fix(gbrain): probe CLI without command builtin#1485

Closed
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1386-gbrain-windows-probe
Closed

fix(gbrain): probe CLI without command builtin#1485
jbetala7 wants to merge 1 commit into
garrytan:mainfrom
jbetala7:oss/fix-1386-gbrain-windows-probe

Conversation

@jbetala7
Copy link
Copy Markdown
Contributor

Fixes #1386

Summary

  • remove the shell-based command -v gbrain probe from gstack-memory-ingest so Windows/Bun does not try to spawn the POSIX shell builtin as an executable
  • use a direct gbrain --help probe in /sync-gbrain while keeping dry-run code-sync previews independent of local gbrain availability
  • add focused regressions that prevent these paths from reintroducing command -v gbrain

Testing

  • bun test test/gstack-gbrain-sync.test.ts
  • bun test test/gstack-memory-ingest.test.ts
  • git diff --check

@garrytan
Copy link
Copy Markdown
Owner

Thank you @jbetala7. Cherry-picked into v1.40.0.0 with attribution preserved (Author: Jayesh Betala). See commit f8e4291. Consolidated v1.40.0.0 fix wave lands as PR #1547. Closing this one as superseded — your contribution is recognized in CHANGELOG.md and the commit metadata.

@garrytan garrytan closed this May 16, 2026
anbangr added a commit to anbangr/gstack that referenced this pull request May 18, 2026
….1.0

Resolved version-slot collision: upstream's v1.40.0.0 was renumbered to
v1.40.0.5 in the CHANGELOG so it slots cleanly between fork's v1.40.0.0
(supervised-restart sweep fix) and v1.40.1.0 (test-framework detection).
All upstream code, tests, and migrations land verbatim — only the version
header on the changelog entry changed.

Conflict resolutions:
- VERSION: kept fork 1.40.1.0
- package.json: kept fork 1.40.1.0
- CHANGELOG.md: kept fork entries (1.40.1.0, 1.40.0.0 supervised-restart)
  + added upstream's gbrain-sync entry renumbered to 1.40.0.5 with a note
  explaining the renumber
- bin/gstack-artifacts-init: took upstream's additive patterns
  (projects/*/*-design-*.md, *-test-plan-*.md, *-eng-review-test-plan-*.md)

Upstream PRs landed in this merge (credits in 1.40.0.5 CHANGELOG entry):
- 0xDevNinja (hostname fold garrytan#1468)
- drummerms (hyphen-boundary cut garrytan#1481)
- Jayesh Betala (probe CLI garrytan#1485)
- Jason Shultz (DATABASE_URL seeding garrytan#1508 + timeout garrytan#1507)
- genisis0x (consumer gitignore garrytan#1521, allowlist eng-review garrytan#1465, Windows postinstall garrytan#1487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: gstack-memory-ingest.ts can't ingest at scale (follow-up to #1271)

2 participants