fix: /freeze and /careful enforcement chain — three independent bugs (#1459)#1509
Open
NikhileshNanduri wants to merge 3 commits into
Open
fix: /freeze and /careful enforcement chain — three independent bugs (#1459)#1509NikhileshNanduri wants to merge 3 commits into
NikhileshNanduri wants to merge 3 commits into
Conversation
…ime (garrytan#1459 Bugs 1+2) Bug 1: link_claude_skill_dirs() in setup and gstack-relink now symlink each skill's bin/ directory alongside SKILL.md. Previously only SKILL.md was linked, so hook scripts referenced in SKILL.md frontmatter (e.g. ${CLAUDE_SKILL_DIR}/bin/check-freeze.sh) resolved to non-existent paths. Bug 2: gstack-settings-hook gains add-pretooluse / remove-pretooluse actions. setup's new Step 11 calls these during install to write freeze and careful PreToolUse entries into ~/.claude/settings.json. Claude Code only fires hooks declared in settings.json — the SKILL.md frontmatter hooks section is documentation; registration must happen separately. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rrytan#1459 Bugs 2+3) Bug 3: check-freeze.sh and check-careful.sh were returning a flat {"permissionDecision":"deny","message":"..."} object. Claude Code requires the hookSpecificOutput envelope: {"hookSpecificOutput":{"hookEventName":"PreToolUse", "permissionDecision":"deny","permissionDecisionReason":"..."}} Without the wrapper the decision is silently ignored and the tool executes. Bug 2 (careful side): check-careful.sh now checks for ~/.gstack/careful-active.txt before inspecting any command; it is a no-op when /careful has not been invoked. careful/SKILL.md now writes that file on activation and explains how to clear it. This makes the globally- registered hook safe to leave in settings.json permanently. check-freeze.sh also resolves its state-root via gstack-paths so it honours GSTACK_HOME in addition to CLAUDE_PLUGIN_DATA / $HOME/.gstack. Tests: all careful tests now use withCarefulActive() and pass CLAUDE_PLUGIN_DATA to the hook. freeze and careful tests assert the new hookSpecificOutput shape. Two new freeze tests verify the envelope format and confirm allow responses remain plain {}. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Three independent bugs all required for hooks to fire and enforce: Bug 1 — bin/ not symlinked (hook script unreachable) Bug 2 — hooks not registered in settings.json (never fires) Bug 3 — wrong hookSpecificOutput format (fires, deny ignored) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #1459:
/freezeand/carefulprovided zero actual enforcement. An Edit outside the freeze boundary would succeed silently despite telemetry logging aboundary_denyevent. Three independent bugs in the install/runtime chain were all required:link_claude_skill_dirssymlinkedSKILL.mdbut notbin/${CLAUDE_SKILL_DIR}/bin/check-freeze.shresolved to a non-existent path — hook invocation always fails silentlyhooks:is decoration — Claude Code only reads~/.claude/settings.json{"permissionDecision":"deny","message":"..."}— flat object, unrecognised by Claude CodeChanges
Bug 1 — bin/ symlink (
setup,bin/gstack-relink):link_claude_skill_dirs()now symlinks each skill'sbin/alongsideSKILL.mdgstack-relinkhas the same fix for the upgrade pathBug 2 — hook registration (
bin/gstack-settings-hook,setup):gstack-settings-hookgainsadd-pretooluse <matcher> <command>andremove-pretooluseactions (idempotent, atomic write via.tmp+ rename)setupStep 11 calls these at install time to write freeze (Edit|Write|MultiEdit) and careful (Bash) entries into~/.claude/settings.jsonBug 3 — hookSpecificOutput format (
freeze/bin/check-freeze.sh,careful/bin/check-careful.sh):{"hookSpecificOutput":{"hookEventName":"PreToolUse","permissionDecision":"deny","permissionDecisionReason":"..."}}check-freeze.shalso resolves its state root viagstack-pathsto honourGSTACK_HOMEin addition toCLAUDE_PLUGIN_DATAcheck-careful.shis now a no-op unless~/.gstack/careful-active.txtexists — safe to leave the hook registered globally without polluting sessions where/carefulwas never invoked./carefulSKILL.md now writes that file and documents how to clear itTests (
test/hook-scripts.test.ts):withCarefulActive()helper and passCLAUDE_PLUGIN_DATAto the hookhookSpecificOutputenvelope shape (2 new tests)Test plan
bun test test/hook-scripts.test.ts— 35 pass, 0 faildocument-generateconfirmed pre-existing on main (stash test)./setup, invoke/freeze src/, attempt Edit on a file outsidesrc/— should be blocked with[freeze] Blocked: .../careful+rm -rf /var— should see permission ask prompt🤖 Generated with Claude Code