Revert "allocator: zero limit in SetExiting for backward compatibility"#463
Merged
williamhbaker merged 1 commit intomasterfrom Mar 19, 2026
Merged
Revert "allocator: zero limit in SetExiting for backward compatibility"#463williamhbaker merged 1 commit intomasterfrom
williamhbaker merged 1 commit intomasterfrom
Conversation
This reverts commit a070522. Allocator deployments going forward must first have been running release v0.102.0 prior to deploying on this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a070522.
Allocator deployments going forward must first have been running release v0.102.0 prior to deploying on this commit.
I did a fresh round of manual tests here to verify that the transition from brokers on
v0.102.0to this one works as it should: Old brokers can stop, and these new ones can replace them. Also when all brokers run this new version, they can be started and stopped individually, or as a rolling deployment; or to simulate the unattended upgrades case they can all be restarted at the same time and end up taking turns restarting.