broker: fragment list Pathpostfix interning#464
Merged
williamhbaker merged 1 commit intomasterfrom Mar 24, 2026
Merged
Conversation
Fragment listings include the PathPostfix for every fragment. This had been constructed by a couple of string slices: (1) In `(*store).List` implementations by a `strings.TrimPrefix`, and (2) in `ParseFragmentFromRelativePath` by `path.Dir`. Taking a slice of a string causes the underlying string to be retained in memory, and this effect is significant if the postfix is relatively short compared to the full fragment path. Additionally, there is often a high degree of overlap in the postfix across journals. This change uses `unique` to canonicalize the Pathpostfix across fragments to address both of these inefficiencies. The original backing strings will no longer be retained in memory, and only a single full postfix will be retained for every unique occurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragment listings include the PathPostfix for every fragment. This had been constructed by a couple of string slices: (1) In
(*store).Listimplementations by astrings.TrimPrefix, and (2) inParseFragmentFromRelativePathbypath.Dir.Taking a slice of a string causes the underlying string to be retained in memory, and this effect is significant if the postfix is relatively short compared to the full fragment path. Additionally, there is often a high degree of overlap in the postfix across journals.
This change uses
uniqueto canonicalize the Pathpostfix across fragments to address both of these inefficiencies. The original backing strings will no longer be retained in memory, and only a single full postfix will be retained for every unique occurrence.