broker: size List response chunks to fit gRPC's 32KB buffer pool tier#466
Merged
williamhbaker merged 1 commit intomasterfrom Apr 7, 2026
Merged
broker: size List response chunks to fit gRPC's 32KB buffer pool tier#466williamhbaker merged 1 commit intomasterfrom
williamhbaker merged 1 commit intomasterfrom
Conversation
Reduce maxJournalsPerListResponse from 1000 to 25 so that marshaled ListResponse messages stay within the 32KB gRPC buffer pool tier. At typical journal sizes (~750-1300 bytes per ListResponse_Journal), 25 journals produces messages of ~19-32KB. Previously, larger chunks produced messages > 32 KB, landing in the 1MB buffer pool tier. When many List watch streams sent responses concurrently, this caused significant memory spikes from pooled 1MB buffers.
williamhbaker
force-pushed
the
wb/list-response-size
branch
from
99a357c to
5c42a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce
maxJournalsPerListResponsefrom 1000 to 25 so that marshaledListResponsemessages stay within the 32KB gRPC buffer pool tier.At typical journal sizes (~750-1300 bytes per
ListResponse_Journal), 25 journals produces messages of ~19-32KB. Previously, larger chunks produced messages > 32 KB, landing in the 1MB buffer pool tier. When many List watch streams sent responses concurrently, this caused significant memory spikes from pooled 1MB buffers.