Skip to content

Transmon qubit example with inductance port#110

Open
mdmaas wants to merge 7 commits into
gdsfactory:mainfrom
EpsilonForge:rebuild/reactive-lumped-elements
Open

Transmon qubit example with inductance port#110
mdmaas wants to merge 7 commits into
gdsfactory:mainfrom
EpsilonForge:rebuild/reactive-lumped-elements

Conversation

@mdmaas
Copy link
Copy Markdown
Contributor

@mdmaas mdmaas commented Apr 16, 2026

This PR was made to enable modelling of a transmon qubit as an "inductance port".

Changes:

  • Emit user resistance/inductance/capacitance as a port with active=false
  • Keep LumpedPort R mapped from port.impedance only.

Debugging tools:

  • Added a validate_mesh() function that checks if the lumped ports are rectangular, and if not, explains which one is failing.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 71.91011% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.18%. Comparing base (e9e4e48) to head (a86c3ec).
⚠️ Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
src/gsim/palace/mesh/validation.py 69.09% 42 Missing and 26 partials ⚠️
src/gsim/palace/mesh/config_generator.py 82.75% 1 Missing and 4 partials ⚠️
src/gsim/palace/models/results.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   46.74%   55.18%   +8.43%     
==========================================
  Files          57       59       +2     
  Lines        6197     6756     +559     
  Branches     1079     1222     +143     
==========================================
+ Hits         2897     3728     +831     
+ Misses       3003     2658     -345     
- Partials      297      370      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdmaas mdmaas changed the title [WIP] split reactive port params into LumpedElement [WIP] Flag lumped ports with reactive params as active=false Apr 16, 2026
@mdmaas mdmaas changed the title [WIP] Flag lumped ports with reactive params as active=false [WIP] Set active=false to lumped ports with reactive params Apr 16, 2026
@mdmaas mdmaas changed the title [WIP] Set active=false to lumped ports with reactive params [WIP] Transmon qubit example with inductance port Apr 16, 2026
mdmaas added 4 commits May 11, 2026 08:33
Keep LumpedPort R mapped from port.impedance only. Emit user resistance/inductance/capacitance as separate LumpedElement entries and propagate these fields through port extraction. Add regression test for expected Boundaries JSON shape.
@dot-cross dot-cross force-pushed the rebuild/reactive-lumped-elements branch from 5e90ef5 to f35a1eb Compare May 11, 2026 13:40
@dot-cross
Copy link
Copy Markdown
Contributor

As the description says: CPW lumped port geometry is distorted and non-rectangular.

Displacing the port to a non curvature section doesn't fix the error.

But increasing the mesh order priority of ports fix it. It seems that a tiny piece of the rectangle was outside the sapphire path, and was cut against the superconductor, which had higher priority.

@mdmaas mdmaas changed the title [WIP] Transmon qubit example with inductance port Transmon qubit example with inductance port May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants