Transmon qubit example with inductance port#110
Open
mdmaas wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 46.74% 55.18% +8.43%
==========================================
Files 57 59 +2
Lines 6197 6756 +559
Branches 1079 1222 +143
==========================================
+ Hits 2897 3728 +831
+ Misses 3003 2658 -345
- Partials 297 370 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Keep LumpedPort R mapped from port.impedance only. Emit user resistance/inductance/capacitance as separate LumpedElement entries and propagate these fields through port extraction. Add regression test for expected Boundaries JSON shape.
5e90ef5 to
f35a1eb
Compare
Contributor
|
As the description says: CPW lumped port geometry is distorted and non-rectangular. Displacing the port to a non curvature section doesn't fix the error. But increasing the mesh order priority of ports fix it. It seems that a tiny piece of the rectangle was outside the sapphire path, and was cut against the superconductor, which had higher priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made to enable modelling of a transmon qubit as an "inductance port".
Changes:
active=falseDebugging tools:
validate_mesh()function that checks if the lumped ports are rectangular, and if not, explains which one is failing.