Skip to content

fix: reorder pyproject.toml sections to satisfy tombi-format#139

Merged
joamatab merged 1 commit into
mainfrom
fix/tombi-format-pyproject
May 17, 2026
Merged

fix: reorder pyproject.toml sections to satisfy tombi-format#139
joamatab merged 1 commit into
mainfrom
fix/tombi-format-pyproject

Conversation

@vvahidd
Copy link
Copy Markdown
Contributor

@vvahidd vvahidd commented May 17, 2026

Summary

Fixes the pre-commit tombi-format failure that occurred during the merge of #135.

Root cause

Commit 7d9ef0b (merge of #135) placed [tool.jupytext] at the end of the TOML tool sections and left [build-system] before [project]. tombi-format v0.7.14 requires:

  • [build-system] after [project] and its dependency groups
  • [tool.*] tables in alphabetical order

Changes

  • Moved [build-system] from the top of the file to after the dependency groups
  • Moved [tool.jupytext] from after [tool.ruff.lint.pydocstyle] to between [tool.interrogate] and [tool.mypy]

Verification

All 27 pre-commit hooks pass:

pre-commit run --all-files  # ✓ All Passed

Move [build-system] after [project] dependency groups and
[tool.jupytext] to its alphabetically-sorted position between
[tool.interrogate] and [tool.mypy].
@github-actions github-actions Bot added the bug Something isn't working label May 17, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the pyproject.toml file by relocating the [build-system] and [tool.jupytext] sections to different positions within the configuration. I have no feedback to provide as there are no review comments and the changes are purely organizational.

Copy link
Copy Markdown
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pyproject.toml formatting fix

@joamatab joamatab merged commit 43f5d38 into main May 17, 2026
9 checks passed
@joamatab joamatab deleted the fix/tombi-format-pyproject branch May 17, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants