Skip to content

[feat : feed notification] add notifications system in-app and email/Slack story scheduled delivery #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
socallmebertille wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[feat : feed notification] add notifications system in-app and email/Slack story scheduled delivery #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dde0a42
Add notifications system with in-app feed, email/Slack delivery, sche…
socallmebertille Aug 19, 2026
3c88a76
align migration on rebase
socallmebertille Aug 19, 2026
a708f89
fix from cubic review
socallmebertille Aug 20, 2026
fd2ec69
add story preview on subscription notif & story in html email body on…
socallmebertille Aug 20, 2026
b548c3b
add filter on user origin
socallmebertille Aug 20, 2026
d778fe2
fix from cubic review
socallmebertille Aug 20, 2026
a37e01e
fix from cubic review
socallmebertille Aug 20, 2026
ff46027
fix last comment from cubic
socallmebertille Aug 21, 2026
dc0675b
fix from cubic comment
socallmebertille Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
226 changes: 226 additions & 0 deletions apps/backend/migrations-postgres/0064_notification_system.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,226 @@
CREATE TABLE "budget_notification" (
"id" text PRIMARY KEY NOT NULL,
"project_id" text NOT NULL,
"provider" text NOT NULL,
"scope" text NOT NULL,
"period_start" timestamp NOT NULL,
"created_at" timestamp DEFAULT now() NOT NULL,
CONSTRAINT "budget_notification_project_provider_scope_period" UNIQUE("project_id","provider","scope","period_start")
);
--> statement-breakpoint
CREATE TABLE "notification" (
"id" text PRIMARY KEY NOT NULL,
"user_id" text NOT NULL,
"project_id" text NOT NULL,
"category" text NOT NULL,
"title" text NOT NULL,
"body" text,
"link_url" text,
"payload" jsonb,
"read_at" timestamp,
"created_at" timestamp DEFAULT now() NOT NULL
);
--> statement-breakpoint
CREATE TABLE "notification_unsubscribe" (
"user_id" text NOT NULL,
"scope" text NOT NULL,
"created_at" timestamp DEFAULT now() NOT NULL,
CONSTRAINT "notification_unsubscribe_user_id_scope_pk" PRIMARY KEY("user_id","scope")
);
--> statement-breakpoint
CREATE TABLE "story_delivery" (
"id" text PRIMARY KEY NOT NULL,
"story_id" text NOT NULL,
"project_id" text,
"enabled" boolean DEFAULT false NOT NULL,
"cron" text,
"schedule_description" text,
"channels" jsonb NOT NULL,
"recipient_mode" text DEFAULT 'specific' NOT NULL,
"recipient_user_ids" jsonb NOT NULL,
"scheduled_job_id" text,
"created_by" text,
"created_at" timestamp DEFAULT now() NOT NULL,
"updated_at" timestamp DEFAULT now() NOT NULL,
CONSTRAINT "story_delivery_story_id_unique" UNIQUE("story_id")
);
--> statement-breakpoint
ALTER TABLE "automation_run" ADD COLUMN "read_at" timestamp;--> statement-breakpoint
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
UPDATE "automation_run" SET "read_at" = "started_at" WHERE "read_at" IS NULL;--> statement-breakpoint
ALTER TABLE "budget_notification" ADD CONSTRAINT "budget_notification_project_id_project_id_fk" FOREIGN KEY ("project_id") REFERENCES "public"."project"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "notification" ADD CONSTRAINT "notification_user_id_user_id_fk" FOREIGN KEY ("user_id") REFERENCES "public"."user"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "notification" ADD CONSTRAINT "notification_project_id_project_id_fk" FOREIGN KEY ("project_id") REFERENCES "public"."project"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "notification_unsubscribe" ADD CONSTRAINT "notification_unsubscribe_user_id_user_id_fk" FOREIGN KEY ("user_id") REFERENCES "public"."user"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "story_delivery" ADD CONSTRAINT "story_delivery_story_id_story_id_fk" FOREIGN KEY ("story_id") REFERENCES "public"."story"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "story_delivery" ADD CONSTRAINT "story_delivery_project_id_project_id_fk" FOREIGN KEY ("project_id") REFERENCES "public"."project"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "story_delivery" ADD CONSTRAINT "story_delivery_scheduled_job_id_scheduled_job_id_fk" FOREIGN KEY ("scheduled_job_id") REFERENCES "public"."scheduled_job"("id") ON DELETE set null ON UPDATE no action;--> statement-breakpoint
ALTER TABLE "story_delivery" ADD CONSTRAINT "story_delivery_created_by_user_id_fk" FOREIGN KEY ("created_by") REFERENCES "public"."user"("id") ON DELETE set null ON UPDATE no action;--> statement-breakpoint
CREATE INDEX "budget_notification_projectId_idx" ON "budget_notification" USING btree ("project_id");--> statement-breakpoint
CREATE INDEX "notification_user_read_idx" ON "notification" USING btree ("user_id","read_at");--> statement-breakpoint
CREATE INDEX "notification_user_project_read_idx" ON "notification" USING btree ("user_id","project_id","read_at");--> statement-breakpoint
CREATE INDEX "notification_createdAt_idx" ON "notification" USING btree ("created_at");--> statement-breakpoint
CREATE INDEX "notification_unsubscribe_userId_idx" ON "notification_unsubscribe" USING btree ("user_id");--> statement-breakpoint
CREATE INDEX "notification_unsubscribe_scope_idx" ON "notification_unsubscribe" USING btree ("scope");--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || pm."user_id",
pm."user_id",
a."project_id",
'shared',
u."name" || ' shared a story with you',
'"' || st."title" || '"',
'/stories/shared/' || ss."id",
jsonb_build_object('kind', 'shared', 'sharerName', u."name", 'itemLabel', 'story', 'itemTitle', st."title", 'visibility', ss."visibility"),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "shared_story" ss ON ss."id" = a."shared_story_id"
JOIN "story" st ON st."id" = a."story_id"
JOIN "user" u ON u."id" = a."user_id"
JOIN (
SELECT p."id" AS "project_id", pm."user_id" AS "user_id"
FROM "project" p JOIN "project_member" pm ON pm."project_id" = p."id"
UNION
SELECT p."id" AS "project_id", om."user_id" AS "user_id"
FROM "project" p JOIN "org_member" om ON om."org_id" = p."org_id"
) pm ON pm."project_id" = a."project_id" AND pm."user_id" <> a."user_id"
WHERE a."type" = 'story.shared'
AND ss."visibility" = 'project'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || ssa."user_id",
ssa."user_id",
a."project_id",
'shared',
u."name" || ' shared a story with you',
'"' || st."title" || '"',
'/stories/shared/' || ss."id",
jsonb_build_object('kind', 'shared', 'sharerName', u."name", 'itemLabel', 'story', 'itemTitle', st."title", 'visibility', ss."visibility"),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "shared_story" ss ON ss."id" = a."shared_story_id"
JOIN "shared_story_access" ssa ON ssa."shared_story_id" = ss."id" AND ssa."user_id" <> a."user_id"
JOIN "story" st ON st."id" = a."story_id"
JOIN "user" u ON u."id" = a."user_id"
WHERE a."type" = 'story.shared'
AND ss."visibility" = 'specific'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || pm."user_id",
pm."user_id",
a."project_id",
'shared',
u."name" || ' shared a chat with you',
'"' || ch."title" || '"',
'/shared-chat/' || sc."id",
jsonb_build_object('kind', 'shared', 'sharerName', u."name", 'itemLabel', 'chat', 'itemTitle', ch."title", 'visibility', sc."visibility"),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "shared_chat" sc ON sc."id" = a."shared_chat_id"
JOIN "chat" ch ON ch."id" = a."chat_id"
JOIN "user" u ON u."id" = a."user_id"
JOIN (
SELECT p."id" AS "project_id", pm."user_id" AS "user_id"
FROM "project" p JOIN "project_member" pm ON pm."project_id" = p."id"
UNION
SELECT p."id" AS "project_id", om."user_id" AS "user_id"
FROM "project" p JOIN "org_member" om ON om."org_id" = p."org_id"
) pm ON pm."project_id" = a."project_id" AND pm."user_id" <> a."user_id"
WHERE a."type" = 'chat.shared'
AND sc."visibility" = 'project'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || sca."user_id",
sca."user_id",
a."project_id",
'shared',
u."name" || ' shared a chat with you',
'"' || ch."title" || '"',
'/shared-chat/' || sc."id",
jsonb_build_object('kind', 'shared', 'sharerName', u."name", 'itemLabel', 'chat', 'itemTitle', ch."title", 'visibility', sc."visibility"),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "shared_chat" sc ON sc."id" = a."shared_chat_id"
JOIN "shared_chat_access" sca ON sca."shared_chat_id" = sc."id" AND sca."user_id" <> a."user_id"
JOIN "chat" ch ON ch."id" = a."chat_id"
JOIN "user" u ON u."id" = a."user_id"
WHERE a."type" = 'chat.shared'
AND sc."visibility" = 'specific'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || COALESCE(st."user_id", ch."user_id"),
COALESCE(st."user_id", ch."user_id"),
a."project_id",
'story_refresh',
st."title",
'Re-ran ' || COALESCE((a."payload"->>'queriesRefreshed')::int, 0) || ' ' || CASE WHEN COALESCE((a."payload"->>'queriesRefreshed')::int, 0) = 1 THEN 'query' ELSE 'queries' END || ' against the latest data.',
COALESCE('/stories/shared/' || ss."id", '/stories/standalone/' || st."id"),

@cubic-dev-ai cubic-dev-ai Bot Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When another member creates a specific share that excludes the story owner, the owner's refresh notification links to that restricted share and returns an access error when clicked. Use the owner's own story URL here, or only select a share that authorizes the owner.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/migrations-postgres/0064_notification_system.sql, line 156:

<comment>When another member creates a specific share that excludes the story owner, the owner's refresh notification links to that restricted share and returns an access error when clicked. Use the owner's own story URL here, or only select a share that authorizes the owner.</comment>

<file context>
@@ -0,0 +1,208 @@
+	'story_refresh',
+	st."title",
+	'Re-ran ' || COALESCE((a."payload"->>'queriesRefreshed')::int, 0) || ' ' || CASE WHEN COALESCE((a."payload"->>'queriesRefreshed')::int, 0) = 1 THEN 'query' ELSE 'queries' END || ' against the latest data.',
+	COALESCE('/stories/shared/' || ss."id", '/stories/standalone/' || st."id"),
+	jsonb_build_object('kind', 'story_refresh', 'storyId', st."id", 'status', 'refreshed', 'queriesRefreshed', COALESCE((a."payload"->>'queriesRefreshed')::int, 0), 'trigger', CASE WHEN a."trigger" = 'manual' THEN 'manual' ELSE 'schedule' END),
+	a."started_at",
</file context>

jsonb_build_object('kind', 'story_refresh', 'storyId', st."id", 'status', 'refreshed', 'queriesRefreshed', COALESCE((a."payload"->>'queriesRefreshed')::int, 0), 'trigger', CASE WHEN a."trigger" = 'manual' THEN 'manual' ELSE 'schedule' END),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "story" st ON st."id" = a."story_id"
LEFT JOIN "chat" ch ON ch."id" = st."chat_id"
LEFT JOIN "shared_story" ss ON ss."story_id" = st."id" AND ss."project_id" = a."project_id"
WHERE a."type" = 'story.refreshed'
AND a."status" = 'completed'
AND COALESCE(st."user_id", ch."user_id") IS NOT NULL
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || pm."user_id",
pm."user_id",
a."project_id",
'story_refresh',
st."title",
'Re-ran ' || COALESCE((a."payload"->>'queriesRefreshed')::int, 0) || ' ' || CASE WHEN COALESCE((a."payload"->>'queriesRefreshed')::int, 0) = 1 THEN 'query' ELSE 'queries' END || ' against the latest data.',
'/stories/shared/' || ss."id",
jsonb_build_object('kind', 'story_refresh', 'storyId', st."id", 'status', 'refreshed', 'queriesRefreshed', COALESCE((a."payload"->>'queriesRefreshed')::int, 0), 'trigger', CASE WHEN a."trigger" = 'manual' THEN 'manual' ELSE 'schedule' END),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "story" st ON st."id" = a."story_id"
JOIN "shared_story" ss ON ss."story_id" = st."id" AND ss."project_id" = a."project_id" AND ss."visibility" = 'project'
JOIN (
SELECT p."id" AS "project_id", pm."user_id" AS "user_id"
FROM "project" p JOIN "project_member" pm ON pm."project_id" = p."id"
UNION
SELECT p."id" AS "project_id", om."user_id" AS "user_id"
FROM "project" p JOIN "org_member" om ON om."org_id" = p."org_id"
) pm ON pm."project_id" = a."project_id"
WHERE a."type" = 'story.refreshed'
AND a."status" = 'completed'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;--> statement-breakpoint
INSERT INTO "notification" ("id", "user_id", "project_id", "category", "title", "body", "link_url", "payload", "read_at", "created_at")
SELECT
'activity-' || a."id" || '-' || ssa."user_id",
ssa."user_id",
a."project_id",
'story_refresh',
st."title",
'Re-ran ' || COALESCE((a."payload"->>'queriesRefreshed')::int, 0) || ' ' || CASE WHEN COALESCE((a."payload"->>'queriesRefreshed')::int, 0) = 1 THEN 'query' ELSE 'queries' END || ' against the latest data.',
'/stories/shared/' || ss."id",
jsonb_build_object('kind', 'story_refresh', 'storyId', st."id", 'status', 'refreshed', 'queriesRefreshed', COALESCE((a."payload"->>'queriesRefreshed')::int, 0), 'trigger', CASE WHEN a."trigger" = 'manual' THEN 'manual' ELSE 'schedule' END),
a."started_at",
a."started_at"
FROM "activity" a
JOIN "story" st ON st."id" = a."story_id"
JOIN "shared_story" ss ON ss."story_id" = st."id" AND ss."project_id" = a."project_id" AND ss."visibility" = 'specific'
JOIN "shared_story_access" ssa ON ssa."shared_story_id" = ss."id"
WHERE a."type" = 'story.refreshed'
AND a."status" = 'completed'
AND a."started_at" >= now() - interval '90 days'
ON CONFLICT DO NOTHING;
Loading
Loading