fix(configuration): treat empty secret as explicit clear#7756
Open
ehooi wants to merge 1 commit into
Open
Conversation
When a user clears a password field in the UI and saves, the empty
string is persisted to the data source options as-is. Downstream SDKs
(e.g. boto3) then receive an explicit empty credential instead of
falling back to the default credential chain, and authentication fails
with empty keys (observed with the Athena data source's
aws_secret_key).
Distinguish the placeholder ("--------", meaning "no change") from an
empty string ("explicit clear") and drop the latter from the stored
options.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
When a user clears a password field in the UI and saves, the empty string is persisted to the data source options as-is. Downstream SDKs (e.g. boto3) then receive an explicit empty credential instead of falling back to the default credential chain, and authentication fails with empty keys (observed with the Athena data source's aws_secret_key).
Distinguish the placeholder ("--------", meaning "no change") from an empty string ("explicit clear") and drop the latter from the stored options.
How is this tested?
Related Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A - backend-only change.