feat(errors): wire up no-silent-catch lint rule, drop ratchet baseline - #1532
Merged
Conversation
The no-silent-catch Biome plugin was added in #1487 but never registered, so the silent-catch backlog was still guarded by the hand-rolled script/silent-catch-baseline.json ratchet. Wire the plugin into biome.jsonc (scoped to src/**/*.ts), grandfather the existing backlog with inline `// biome-ignore lint/plugin` comments, and run lint with --error-on-warnings so an orphaned suppression fails as suppressions/unused — the same shrink-only ratchet, enforced by the linter instead of a bespoke script + JSON baseline. Trim the silent-catch detection and baseline machinery out of check-error-patterns.ts (it still checks ContextError newlines and ad-hoc CliError "Try:" strings) and its tests, and delete the baseline file. Fixes #1531
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Deployment notification only — no action needed. |
Contributor
Author
|
CI green, self-review clean, ready for review. The ratchet is now the Biome plugin + --error-on-warnings (unused suppressions fail). |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 48d910a. Configure here.
BYK
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the root cause from #1513's discussion: the
no-silent-catchBiome plugin was added in #1487 but never registered, so silent catches were still guarded by the hand-rolledscript/silent-catch-baseline.jsonratchet. This wires the plugin intobiome.jsonc(scoped tosrc/**/*.ts), grandfathers the existing backlog with inline// biome-ignore lint/plugincomments, and runspnpm run lintwith--error-on-warningsso an orphaned suppression fails assuppressions/unused— the same shrink-only ratchet, now enforced by the linter instead of a bespoke script + JSON baseline.check-error-patterns.tskeeps its two hard checks (ContextError newlines, ad-hocCliError "Try:"strings); only the silent-catch detection and baseline machinery are removed, along withsilent-catch-baseline.json.Testing
pnpm run lint(with--error-on-warnings) — clean, 0 silent catches / 0 unused suppressionspnpm run check:errors— passesvitest run test/script/check-error-patterns.test.ts— 5 passingCloses #1531