fix(linear): track only sub-issues as action items and re-enable parent reopen#262
Merged
Merged
Conversation
…nt reopen Only child (sub-)issues of the Linear parent are synced as action items; related/blocking/duplicate relations are no longer treated as action items. This removes the source of confusion behind #261, where loosely related issues dragged the parent's auto-status around. With action items now scoped to true sub-issues, re-enable the two-way parent status sync (revert #261's one-way change): the parent advances to Completed when the incident is resolved and all sub-issues are done, and reopens to Started when the incident is reopened or sub-issues remain. Restores the Started status-change comment and its config key. Captain-change assignee sync from #261 is left untouched.
Dual-review follow-ups: - Document the auto-completion direction in the parent issue description (it was only describing reopen). - Handle the zero-action-items case in the Started status comment template, mirroring the Completed template. - Restore CANCELED-incident -> completed parent-status test coverage. - Reuse the COMPLETED_STATUSES constant instead of an inline literal.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
The re-enabled two-way parent status sync would force a parent whose Linear state was manually set to 'canceled' back to 'started' on every sync while the incident is active (and to 'completed' once resolved), because the skip guard only matched the exact target state. Firetower only ever drives the parent to 'started'/'completed', so treat 'canceled' as a terminal human decision and leave it untouched. Reported by Warden (MAV-TB5).
rgibert
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #261. A user flagged that Firetower was treating loosely-related Linear issues as incident action items, which then dragged the parent issue's auto-status around — the confusing behavior #261 tried to fix by making parent status one-way (complete-only, never reopen).
This change addresses the root cause instead:
get_related_issues/_fetch_relations/LINEAR_RELATION_TYPE_MAPare removed.PARENT_STATUS_COMMENT_STARTED(still present in the prodconfig.toml).LINEAR_PARENT_DESCRIPTIONto say only sub-issues are tracked and that the ticket will both auto-complete and reopen.The captain-change assignee sync from #261 is left untouched. The
relation_typefield onActionItemis intentionally kept (now alwayschild).