chore: Mark http.query/http.fragment stripping for v11 url.query migration#21852
Merged
Conversation
…rl.query migration Add TODO(v11) markers at the two spots that strip the leading `?`/`#` from `http.query`/`http.fragment`, noting the v11 move to the OTel-standard `url.query`/`url.fragment` (no leading char). Comment-only, no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264 and
mydea
and removed request for
a team
andreiborza
changed the title
nicohrubec
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
TODO(v11)markers at the two spots that strip the leading?/#fromhttp.query/http.fragment— the span exporter'sgetDataandparseSpanDescription'sdescriptionForHttpMethod.Per the discussion on #21848,
http.queryis specced to keep the leading?, so the stripping diverges from our own conventions. The v11 direction is to emit the OTel-standardurl.query/url.fragment(no leading char, already in@sentry/conventions) and drophttp.query/http.fragment.Comment-only, no behavior change.