Skip to content

chore(hybridcloud) Remove dynamic default_flush on ApiToken#119017

Draft
markstory wants to merge 1 commit into
masterfrom
chore-api-token-async
Draft

chore(hybridcloud) Remove dynamic default_flush on ApiToken#119017
markstory wants to merge 1 commit into
masterfrom
chore-api-token-async

Conversation

@markstory

@markstory markstory commented Jul 3, 2026

Copy link
Copy Markdown
Member

We can't easily make ApiToken flush async because of read-after write usage in cell endpoints. Remove the rollout option & tests for this experiment.

Refs #105264

We can't easily make ApiToken flush async because of read-after write
usage in cell endpoints. Remove the rollout option & tests for this
experiment.
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on c222247 in this run:

tests/sentry/models/test_apitoken.py::ApiTokenInternalIntegrationTest::test_async_replication_schedules_drain_tasklog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/models/test_apitoken.py:360: in test_async_replication_schedules_drain_task
    assert mock_drain_task.called
E   AssertionError: assert False
E    +  where False = <MagicMock name='delay' id='139812395279632'>.called
tests/sentry/models/test_apitoken.py::ApiTokenInternalIntegrationTest::test_multiple_tokens_use_different_shardslog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/models/test_apitoken.py:390: in test_multiple_tokens_use_different_shards
    assert token_1_outboxes.exists()
E   assert False
E    +  where False = exists()
E    +    where exists = <BaseQuerySet []>.exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant