chore(hybridcloud) Remove dynamic default_flush on ApiToken#119017
Draft
markstory wants to merge 1 commit into
Draft
chore(hybridcloud) Remove dynamic default_flush on ApiToken#119017markstory wants to merge 1 commit into
markstory wants to merge 1 commit into
Conversation
We can't easily make ApiToken flush async because of read-after write usage in cell endpoints. Remove the rollout option & tests for this experiment.
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't easily make ApiToken flush async because of read-after write usage in cell endpoints. Remove the rollout option & tests for this experiment.
Refs #105264