fix: vendor ate.dev CRDs so substrate status endpoint degrades gracefully#101
Closed
QuentinBisson wants to merge 1 commit into
Closed
fix: vendor ate.dev CRDs so substrate status endpoint degrades gracefully#101QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
…ully kagent hard-500s on /api/substrate/status when the ate.dev CRDs (WorkerPool, ActorTemplate) are absent because listSubstrateCRs propagates the REST mapper NoKindMatchError as a server error. This causes the Chat UI "New Chat" input to fail with "Failed to fetch servers". Vendor the two CRDs from agent-substrate/substrate so the REST mapper knows the types and the endpoint returns 200 with an empty resource list. Remove once we pin a kagent release that includes the upstream fix (kagent-dev/kagent#2023).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
kagent returns HTTP 500 on
/api/substrate/statuswhen theagent-substrateCRDs(
ate.dev/v1alpha1WorkerPool / ActorTemplate) are not installed. This breaks theChat UI "New Chat" input with "Failed to fetch servers".
Root cause:
listSubstrateCRspropagates the REST mapperNoKindMatchErroras aserver error instead of treating it as "substrate not installed".
Fix
Vendor the two CRDs from
agent-substrate/substrateintohelm/agentic-platform-crds/templates/so the REST mapper knows the types and returns an empty list instead of erroring.
Stopgap only. Remove once we pin a kagent release that includes the upstream fix
(kagent-dev/kagent#2023, issue kagent-dev/kagent#2024).
Tracked in giantswarm/giantswarm#36845.