[GHSA-h5x4-m2qf-r4f2] Diesel's SQLite backend has possible UTF-8 corruption#7674
[GHSA-h5x4-m2qf-r4f2] Diesel's SQLite backend has possible UTF-8 corruption#7674weiznich wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub-reviewed advisory record for GHSA-h5x4-m2qf-r4f2 (Diesel SQLite UTF-8 corruption) to reflect revised severity classification metadata (CVSS v4 vector, CWE list, and GitHub “severity”).
Changes:
- Updates the CVSS v4 vector (notably
ATand impact metrics). - Removes the previously assigned CWE (
CWE-89) and setscwe_idsto an empty list. - Lowers
database_specific.severityfromHIGHtoLOW.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "type": "CVSS_V4", | ||
| "score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N" | ||
| "score": "CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:N/SC:N/SI:N/SA:N" | ||
| } |
There was a problem hiding this comment.
I don't think this correct, given the requirements to trigger this at all.
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Updates
Comments
This is no SQL injection, but an broken safety invariant while deserializing data coming from the database.
Any attacker would need to have arbitrary write access to the database so that they can insert arbitrary binary data into a column where the application code using diesel expects an UTF-8 string. That usually requires that the attacker circumvents the normal way to insert data into this field as it can be assumed that almost always a string (that is utf-8) is used for that purpose. Based on this I suggest to change Attack Requirements (AT) to present and also Integrity to none (as there is no way that I'm aware of to use this to actually modify data as everything happens during deserialization)