refactor(network): remove orphaned internal-service MCP host allowlists#996
Merged
Conversation
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
June 13, 2026 14:54
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_required_hosts()silently auto-added Microsoft-internal hosts to the network allowlist whenever a user'smcp-servers:key matched a hardcoded identifier (kusto,icm,bluebird,es-chat,msft-learn,asa,stack,calculator,github). These arms predateado-aw, were inherited from the initial compiler import, and escaped the "remove built-in MCP concept" purge (f25c15b) that deletedmcp-metadata.json,mcp_firewall.rs, andmcp_metadata.rs.Changes (
src/allowed_hosts.rs):_ => &[]— users declare hosts explicitly vianetwork.allowed, like any other custom MCP.ado/ado-extarm, still consumed by the always-on azure-devops tool extension (src/tools/azure_devops/extension.rs). Droppinggithubis a no-op since GitHub hosts are already inCORE_ALLOWED_HOSTS.test_mcp_hosts_kustowithtest_mcp_hosts_ado; addedtest_mcp_hosts_internal_services_removedto lock in the removal.Follow-up: draft PR #967, which documented these orphans as intended behavior, should be closed rather than merged.
Test plan
cargo test --bin ado-aw— 1838 passedcargo clippy --all-targets --all-features— cleancomplete-agent.mdfixture (which uses these names as generic MCP keys) still compiles to valid YAML; no test asserted on the auto-added hosts.