Make overlays (e.g. pickers) fullscreen - original helix PR [#12311](https://github.com/helix-editor/helix/pull/12311)

[RokKos]

Porting this improvement from the original helix PR #12311. As it's simple change and it improves the editor.

I like the minimal look and that it adds a bit more of the preview space.

Old behaviour:

New behaviour:

[gj1118]

@RokKos can we please put this behind a setting? I am on a large monitor and usually I can see some code behind while the picker is open, so it gives some context to see which file I am on, so on and so forth. What do you think? Please let me know!

[RokKos]

For sure, we can put this behind the setting.
For my workflow, when I open a picker, I usually don't care about the underlying buffer.
But I can see how this could be beneficial to see some context that you are currently in.

Do you have any good name for this setting?
What do you think about 'pickers-full-screen'?

[gj1118]

For sure, we can put this behind the setting. For my workflow, when I open a picker, I usually don't care about the underlying buffer. But I can see how this could be beneficial to see some context that you are currently in.

Do you have any good name for this setting? What do you think about 'pickers-full-screen'?

I would suggest to have it as "full-screen-pickers". What do you think ?

[RokKos]

I am okay with either naming; I personally name stuff with the first word that has the most meaning. In this case, this setting is for the picker being full-screen and not the full-screen behaviour of pickers. If my logic makes sense.

But I can adapt, and if there is any guide on code style, I am willing to conform to that.

[gj1118]

I am okay with either naming; I personally name stuff with the first word that has the most meaning. In this case, this setting is for the picker being full-screen and not the full-screen behaviour of pickers. If my logic makes sense.

But I can adapt, and if there is any guide on code style, I am willing to conform to that.

I havent thought of a particular naming style, since I was the only person who was working on this fork. But you bring up a very good point. Thanks once again - Should we follow the same rule set by the helix. that will make the code consistent. Please let me know what you think. And thanks for asking these very valid questions. Much appreciated!