feat: Allow custom range and interval in market widget#978
Open
suffer-sami wants to merge 1 commit intoglanceapp:devfrom
Open
feat: Allow custom range and interval in market widget#978suffer-sami wants to merge 1 commit intoglanceapp:devfrom
suffer-sami wants to merge 1 commit intoglanceapp:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #974
Summary
This PR adds support for customizing the range and interval parameters used when fetching chart data for the market widget.
Previously, the API request hardcoded these values:
https://query1.finance.yahoo.com/v8/finance/chart/%s?range=1mo&interval=1dThis now allows us to use custom range and also to fetch data for symbols that require different parameters as mentioned in issue #974 (e.g.
VNINDEXonly returns data with a4hinterval and a short range).Changes
rangeandintervalfields to themarketRequeststructrange: 1mo/interval: 1dwhen not specified (fully backwards compatible)docs/configuration.mdwith the new properties and valid valuesExample
Screenshot