fix: handle HTTPS Docker endpoints without downgrading to HTTP#999
Open
sjhddh wants to merge 1 commit intoglanceapp:mainfrom
Open
fix: handle HTTPS Docker endpoints without downgrading to HTTP#999sjhddh wants to merge 1 commit intoglanceapp:mainfrom
sjhddh wants to merge 1 commit intoglanceapp:mainfrom
Conversation
Docker containers widget silently downgrades HTTPS to HTTP because: 1. The prefix check only matches tcp:// and http://, so https:// falls through to the Unix socket code path 2. The request URL hardcodes 'http://' prefix This patch adds https:// to the prefix check, preserves the parsed URL scheme, and defaults the port to 443 for HTTPS connections. Fixes glanceapp#992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://endpoints tohttp://https://prefix was missing from the scheme check, causing HTTPS URLs to fall through to the Unix socket code pathhttp://, so even if parsed correctly, HTTPS would be lostChanges
https://to the prefix check infetchDockerContainersFromSourcehttp://tcp://→http://(preserving existing behavior)443for HTTPS,80for HTTP/TCPTest plan
go test ./...passestcp://andhttp://endpoints still work as beforeFixes #992