chore: refresh the semconv fixture from the Python SDK - #28
Merged
Conversation
Picks up SERVICE_INSTANCE_ID = "service.instance.id", which Python gained when service.instance.id shipped here in #24. Purely a stale mirror: src/semconv.ts already exports that constant with that value, so the parity test never had anything to catch — the test walks the FIXTURE's keys, and a key the fixture lacks is simply never compared. Only the weekly regenerate-and-diff check saw it, which is what opened #25. Closes #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
The weekly parity check found one added constant:
"TRACER_NAME": "glassflow", + "SERVICE_INSTANCE_ID": "service.instance.id",Purely a stale mirror.
src/semconv.ts:8already exportsSERVICE_INSTANCE_ID = "service.instance.id"— it shipped in #24 — so Python and this SDK have agreed all along. Only the committed fixture lagged.The parity test never had anything to catch, because it walks the fixture's keys and compares each against
src/semconv.ts; a key the fixture lacks is never compared at all. The weekly regenerate-and-diff is what noticed, and that is what opened #25.224 passedwith the refreshed fixture, so this is the benign class of drift: the regenerated mirror keeps the suite green. Had Python added a constant this SDK genuinely lacked, the test would now be red and would need a human to port it or declare it inPYTHON_ONLY.That distinction is the basis of a follow-up PR reworking
semconv-parity.ymlso mechanical drift like this opens a PR instead of an issue.