Skip to content

root: fix make gen-changelog#24122

Open
emilburzo wants to merge 1 commit into
mainfrom
fix-gen-changelog
Open

root: fix make gen-changelog#24122
emilburzo wants to merge 1 commit into
mainfrom
fix-gen-changelog

Conversation

@emilburzo

Copy link
Copy Markdown
Member

Fixes this:

$ git checkout version-2026.5
$ make gen-changelog last_version=version/2026.5.4
grep: warning: stray \ before d
git log --pretty=format:"- %s" c2942671a5b98dfa596de7bf247accb48a5c71ee...8704a1b89d7bf46bcef0d3c434c821b937fdecc3 > merged_to_current
git log --pretty=format:"- %s" c2942671a5b98dfa596de7bf247accb48a5c71ee...version/2026.5.4 > merged_to_last
grep -Eo 'cherry-pick (#\d+)' merged_to_last | cut -d ' ' -f 2 | sed 's/.*/(&)$/' > cherry_picked_to_last
grep: warning: stray \ before d
make: *** [Makefile:187: gen-changelog] Error 1

Changes

  • use portable [0-9] instead of \d
  • handle empty cherry-pick list (because of pipefail)

@emilburzo
emilburzo requested a review from a team as a code owner July 16, 2026 15:23
Copilot AI review requested due to automatic review settings July 16, 2026 15:23
@emilburzo emilburzo moved this from Todo to Needs review in authentik Core Jul 16, 2026
@emilburzo emilburzo added the backport/version-2026.5 Add this label to PRs to backport changes to version-2026.5 label Jul 16, 2026
@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 9171756
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6a58f75bf20d0b0007797406
😎 Deploy Preview https://deploy-preview-24122--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes make gen-changelog (and the related tag-selection in gen-diff) so it works reliably across different grep implementations and doesn’t fail when there are no cherry-picks to extract (with bash -o pipefail enabled).

Changes:

  • Replace non-portable \d with portable [0-9] in grep -E expressions.
  • Prevent the gen-changelog pipeline from failing when grep finds no cherry-pick #<n> matches by making the grep stage non-fatal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@emilburzo emilburzo self-assigned this Jul 16, 2026
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.79%. Comparing base (0c237e8) to head (9171756).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24122      +/-   ##
==========================================
- Coverage   92.83%   92.79%   -0.05%     
==========================================
  Files        1056     1056              
  Lines       62751    62751              
  Branches      424      424              
==========================================
- Hits        58256    58228      -28     
- Misses       4495     4523      +28     
Flag Coverage Δ
conformance 35.56% <ø> (+<0.01%) ⬆️
e2e 40.60% <ø> (ø)
integration 31.54% <ø> (-0.48%) ⬇️
rust 0.00% <ø> (ø)
unit 92.00% <ø> (ø)
unit-migrate 92.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9171756d5aa535dac2a185ff0badc8ba8c0add9d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9171756d5aa535dac2a185ff0badc8ba8c0add9d

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2026.5 Add this label to PRs to backport changes to version-2026.5

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants