Add proper empty Resource handling in Polygon3D editor#121731
Open
KoBeWi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
See #118486 (comment)
This replaces the editor hack in OccluderInstance3D with an internal signal that notifies the editor that editing status may have changed. The editor's code was changed to handle it.
Additional information
With this PR, Polygon3DEditor has a concept of "empty" state, i.e. a state where it doesn't have edited node, or the node doesn't have valid polygon resource. Note that the polygon editor can edit both nodes and their resources, so I added a kind of "resource mode", which is determined by the existence of
_get_editable_3d_polygon_resource()method. The method can now return null and it makes the editor inactive until a valid resource is assigned to node. The newly added_editable_3d_polygon_changedsignal is intended for notifying the editor about polygon object changes.The OccluderInstance3D is no longer conditionally editable. The editor will always edit it, but stay inactive if the occluder does not have polygon assigned.
I think similar logic may need to be applied in other nodes, if their polygon object can change. We might have some undiscovered bugs here.