Update Add Action button Disabled Status when Removing any action#121766
Open
og-mrk wants to merge 1 commit into
Open
Update Add Action button Disabled Status when Removing any action#121766og-mrk wants to merge 1 commit into
og-mrk wants to merge 1 commit into
Conversation
…ction Makes sure the add action button is enabled when the action name the user wants to add is equal to recently removed action inside the tree. without this change, the add button will remain disabled (even though it's a valid action name), making the user feel the GUI is unresponsive.
og-mrk
force-pushed
the
editor/20260725-action_map_editor-handling_edge_case
branch
from
July 25, 2026 14:50
af0b0b4 to
545a8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Description
Makes sure the add action button is enabled when the action name the user wants to add is equal to recently removed action inside the tree. without this change, the add button will remain disabled (even though it's a valid action name), making the user feel the GUI is unresponsive.
Testing
Before Changes
add_action_button_before_changes.mp4
After Changes
add_action_button_after_changes.mp4
Additional information
Enter, but I think if it's valid to do this using shortcuts, it's should be the same using UI components (through the add button in this case).Reason behind calling the_add_edit_text_changedcallback is because it does all the validation needed when deciding to Enable or Disable theAdd Actionbutton, and setting tooltip text, so calling it makes more sense then code duplication.After further reading the code, it does alot of unnecessary checks that we know can not happen (EditLine containing invalid Action Name.. Looping over entire Actions Cache when we care about one case), so for this reason, we'll simply check if what's inside EditLine == name of removed action, which has the side effect of making the code self documenting. (link to changes)
Use of AI
No AI was used in the process of making these changes.