Conversation
|
/gemini-review |
1 similar comment
|
/gemini-review |
|
Hi @yarolegovich and @dpasiukevich — thanks for working on this. We ran into the gap this PR fixes while integrating our ADK-based agent with a remote A2A server that implements protocol v1.0 via a2a-go/v2 (HTTP+JSON transport, To unblock ourselves we pinned our project to this PR's head ( A couple of questions, if you have a moment:
Thanks again — this PR lands exactly the API we need, and the split into |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the remote agent and A2A server components to integrate version 2 of the A2A SDK while maintaining backward compatibility for legacy configurations. The review feedback highlights several critical issues where errors from SDK conversion functions—specifically those handling events, artifacts, and message requests—are ignored, which could lead to runtime panics or silent failures. Additionally, a redundant conditional check in the client factory logic was identified as an opportunity for code simplification.
|
@ysyneu thanks for confirming there's demand for it, we'll resume the work on it |
7be3e54 to
4845857
Compare
|
Just pinned the branch ( |
What this gives is that ADK can be used with a2a-go/v2 which implements A2A protocol v1 (as well as v0).