test(adkrest/models): add EventActions field mapping coverage#726
Open
nuthalapativarun wants to merge 4 commits intogoogle:mainfrom
Open
test(adkrest/models): add EventActions field mapping coverage#726nuthalapativarun wants to merge 4 commits intogoogle:mainfrom
nuthalapativarun wants to merge 4 commits intogoogle:mainfrom
Conversation
Add table-driven tests for FromSessionEvent and ToSessionEvent to verify that TransferToAgent, Escalate, and SkipSummarization are correctly mapped in both directions. Includes a round-trip test. Closes google#509
Author
|
Hi, just checking in on this one — happy to make any adjustments if something needs to change. Let me know if there's anything blocking review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem:
FromSessionEventandToSessionEventwere missingTransferToAgent,Escalate, andSkipSummarizationfields in the REST APIEventActionsstruct (issue #509). The fix was merged in #609, but there were no tests to prevent regressions.Solution:
Add table-driven tests covering all three fields for both
FromSessionEventandToSessionEvent, plus a round-trip test (FromSessionEvent→ToSessionEvent) to verify noEventActionsfields are lost.Closes #509
Testing Plan
Unit Tests:
TestFromSessionEvent_EventActions— 5 table cases (all fields, each field individually, zero value)TestToSessionEvent_EventActions— same 5 cases for reverse directionTestFromSessionEvent_RoundTrip— full round-trip testChecklist
Additional context
This PR adds regression test coverage only — no production code changes. The underlying fix was already merged in #609.
Authored by Varun Nuthalapati using AI coding assistance (Claude)