chore: add compile-time interface assertions for tool implementations#750
Open
merkulovlad wants to merge 1 commit intogoogle:mainfrom
Open
chore: add compile-time interface assertions for tool implementations#750merkulovlad wants to merge 1 commit intogoogle:mainfrom
merkulovlad wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem:
Currently, explicit compile-time checks exist only for the MCP tool via
RequestProcessorandFunctionTool. Other tooltypes rely on runtime validation in
base_flow, which makes interface conformance checks less explicit.Solution:
Add compile-time
var _interface assertions to all tool implementations that implementtoolinternal.RequestProcessorand/or
toolinternal.FunctionTool, consistent with the existing pattern inmcpTool.Testing Plan
No tests needed.
This PR only adds explicit compile-time interface checks and does not change runtime behavior.
Checklist