fix: check for NotFound error before auto-creating session (#751)#753
Open
indurireddy-TF wants to merge 2 commits intogoogle:mainfrom
Open
fix: check for NotFound error before auto-creating session (#751)#753indurireddy-TF wants to merge 2 commits intogoogle:mainfrom
indurireddy-TF wants to merge 2 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Runner to conditionally allow automatic session creation only when a NotFound error is returned. A review comment suggests that using gRPC-specific status codes for this check introduces unnecessary coupling and may fail to correctly identify wrapped errors or support non-gRPC service implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
The code treats all network or database errors as a missing session, silently overwriting existing user data when a temporary failure occurs.
Solution:
Add an check so the framework only auto-creates a new session when it confirms the session actually does not exist.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed go test results.
Manual End-to-End (E2E) Tests:
Checklist
Additional context