Skip to content

fix: use sandbox mime_type input field #6094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malsabbagh05 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: use sandbox mime_type input field #6094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/google/adk/code_executors/agent_engine_sandbox_code_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def execute_code(
{
'name': f.name,
'content': f.content,
'mimeType': f.mime_type,
'mime_type': f.mime_type,
}
for f in code_execution_input.input_files
]
Expand Down
6 changes: 3 additions & 3 deletions tests/unittests/code_executors/test_agent_engine_sandbox_code_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ def test_execute_code_success(
)

@patch("vertexai.Client")
def test_execute_code_sends_input_files_with_content_key(
def test_execute_code_sends_input_files_with_sandbox_api_fields(
self,
mock_vertexai_client,
mock_invocation_context,
):
"""Input files must be sent under the 'content' key the SDK expects."""
"""Input files must use the field names the sandbox API expects."""
mock_api_client = MagicMock()
mock_vertexai_client.return_value = mock_api_client
mock_response = MagicMock()
Expand All @@ -157,7 +157,7 @@ def test_execute_code_sends_input_files_with_content_key(
)
sent_files = call_kwargs["input_data"]["files"]
assert sent_files == [
{"name": "data.csv", "content": "a,b,c", "mimeType": "text/csv"}
{"name": "data.csv", "content": "a,b,c", "mime_type": "text/csv"}
]

@patch("vertexai.Client")
Expand Down