TUI: add interactive /config menu for per-request harness config#235
Merged
Conversation
rakyll
approved these changes
Jul 1, 2026
rakyll
left a comment
rakyll
left a comment
Member
There was a problem hiding this comment.
Left comments but otherwise LGTM.
| if s == "" { | ||
| return nil, nil | ||
| } | ||
| if err := protojson.Unmarshal([]byte(s), &structpb.Struct{}); err != nil { |
Member
There was a problem hiding this comment.
We should turn harness_config into a bytes field. Proto encoding makes no sense outside of Google.
Collaborator
Author
There was a problem hiding this comment.
Replaced protojson by json, for config format checking.
| // returns done=true if the config was updated, or false if the user cancelled | ||
| // back to the menu. Invalid JSON is reported and the editor re-opens with the | ||
| // user's draft so they can fix it. | ||
| func editHarnessConfig(d *internal.Display, harnessConfig *[]byte) (bool, error) { |
Member
There was a problem hiding this comment.
You have a pointer to a byte slice here. Remote it.
Replace the argument with harnessConfig []byte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/configslash command in the prompt box, with autocompletion suggestion.not carry over
Tested both locally and on substrate.