Fix ProtectedMembersInFinalClass to avoid suggesting removing protected from canonical constructors of protected record classes.#5946
Merged
Conversation
…ted` from canonical constructors of `protected` record classes. Along the way, introduce `ASTHelpers.isCanonicalRecordConstructor` to share some logic. Compare 1bb55ab. PiperOrigin-RevId: 942157685
copybara-service
Bot
force-pushed
the
test_941808520
branch
from
acad01e to
2be3abd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ProtectedMembersInFinalClass to avoid suggesting removing
protectedfrom canonical constructors ofprotectedrecord classes.Along the way, introduce
ASTHelpers.isCanonicalRecordConstructorto share some logic.Compare 1bb55ab.