Move PreferPreconditions to JavaCodeClarity to run on changed lines#5947
Merged
Conversation
and only emit findings if `Preconditions` is already on the classpath. This check is producing a lot of findings on unchanged lines and for third_party/ code that doesn't depend on Guava (like SafeRE). PiperOrigin-RevId: 942497251
copybara-service
Bot
force-pushed
the
test_942464213
branch
from
462196f to
c75dd09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move PreferPreconditions to JavaCodeClarity to run on changed lines
and only emit findings if
Preconditionsis already on the classpath.This check is producing a lot of findings on unchanged lines and for third_party/ code that doesn't depend on Guava (like SafeRE).