Avoid C++ verifier template name collisions - #9217
Open
xThreeh wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
python
c++
codegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9066.
A C++ table field named
Bcurrently collides with the generated verifier template parameterB, producing invalid code such asverifier.VerifyTable(B()).This renames the generated template parameter to
VerifySizePrefixedand adds a focused regression that generates and compiles a schema containing aBfield.Validation:
cmake --build build-collision --target flatcpython3 tests/test_cpp_field_name_collision.py build-collision/flatcc++ -std=c++11 -fsyntax-only.