feat: Add Issue Dependencies API support by tommaso-moro · Pull Request #4130 · google/go-github

tommaso-moro · 2026-04-02T14:09:38Z

closes: #4129

Add Issue Dependencies API support

Add support for the Issue Dependencies REST API.

Changes

New file github/issues_dependencies.go adds four methods to IssuesService:

Method	Endpoint	Description
`ListBlockedBy`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	List dependencies blocking an issue
`AddBlockedBy`	`POST /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by`	Add a blocking dependency
`RemoveBlockedBy`	`DELETE /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocked_by/{issue_id}`	Remove a blocking dependency
`ListBlocking`	`GET /repos/{owner}/{repo}/issues/{issue_number}/dependencies/blocking`	List issues this issue is blocking

Also adds IssueDependencyRequest type used by AddBlockedBy.

Testing

Full test coverage in github/issues_dependencies_test.go (12 tests) using standard helpers: testBadOptions, testNewRequestAndDoFailure, testURLParseError, testJSONMarshal.

Auto-generated files updated via go generate: accessors, accessor tests, iterators, and iterator tests.

All scripts pass: script/fmt.sh, script/test.sh, script/lint.sh.

Add four new methods to IssuesService for the Issue Dependencies REST API (apiVersion 2026-03-10): - ListBlockedBy: list dependencies blocking an issue - AddBlockedBy: add a blocking dependency to an issue - RemoveBlockedBy: remove a blocking dependency - ListBlocking: list issues that an issue is blocking Includes IssueDependencyRequest type, full test coverage with testBadOptions, testNewRequestAndDoFailure, testURLParseError, and testJSONMarshal helpers.

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

google-cla · 2026-04-02T14:09:50Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov · 2026-04-02T14:18:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (216f315) to head (0b1ed3a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   97.47%   97.48%   +0.01%     
==========================================
  Files         192      193       +1     
  Lines       19320    19400      +80     
==========================================
+ Hits        18832    18912      +80     
  Misses        270      270              
  Partials      218      218

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis

Thank you, @tommaso-moro!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

tommaso-moro · 2026-04-08T09:12:21Z

@Not-Dhananjay-Mishra thank you for the review! I have addressed the points you raised and updated this branch.

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

…dependencies.go Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

gmlewis

Sorry, @tommaso-moro - but I'm not OK with the changes to gen-stringify-test.go that were made since my last code review (and prior approval).

There should be no reason to add this extra maintenance burden to this code.

I'm going to have to go through all the comments and try to figure out why you added this.

…dencies-support # Conflicts: # github/github-accessors.go # github/github-accessors_test.go # github/issues.go

tommaso-moro · 2026-06-19T16:30:32Z

Apologies for letting this sit so long. Thanks for your patience, and for the earlier reviews @gmlewis @alexandear.

@gmlewis you were right about gen-stringify-test.go. I've reverted it entirely, so it's now identical to master and the special-case map is gone. On what was actually breaking: I'd made the IssueDependenciesSummary/SubIssuesSummary fields value-int (per @alexandear's point that they're required in the schema), but value ints always render in Stringify, which is what made TestIssue_String fail and what I'd been papering over with that map.
My hunch is that we could make those count fields *int + ,omitempty instead as that seems to match how the other count-summary response structs already work (IssueStats, CommentStats, etc.) and keeps the structfield linter happy? @alexandear, this does walk back your value-int suggestion on those two structs, so please push back if I've got it wrong. I kept your other changes (request IssueID stays value int64, issueNumber int64, and the rest).

Also merged in the latest master and resolved the conflicts.

gmlewis

Thank you, @tommaso-moro!
Just one question and one minor nit, otherwise LGTM.

gmlewis · 2026-06-22T14:34:24Z

@tommaso-moro - unfortunately, it looks like multiple commits were made from different email accounts... some which signed the CLA and some which haven't. To fix this, you can either sign the CLA using all emails, or force-push a fixed PR with only commits from the signed CLA. Until then, we can't consider merging this PR. I apologize for the inconvenience.

EDIT: Resolved, thank you!

Addresses review feedback that issueNumber and issueID are easy to confuse. blockingIssueID makes it clear which issue is being removed as a blocker.

IssueDependencyRequest has no custom MarshalJSON, so the test only exercises the standard library's encoding/json. Per the project convention (google#4253), marshal tests are reserved for types with custom (Un)MarshalJSON implementations.

gmlewis

LGTM.

cc: @alexandear - @Not-Dhananjay-Mishra

Not-Dhananjay-Mishra

LGTM

gmlewis · 2026-06-22T16:55:59Z

Thank you, @tommaso-moro , @Not-Dhananjay-Mishra , @alexandear, and @munlicode!
Merging.

tommaso-moro added 2 commits April 2, 2026 11:27

chore: Regenerate accessors and iterators

9aba995

Run go generate to add: - GetIssueID accessor for IssueDependencyRequest - ListBlockedBy and ListBlocking iterators with tests

tommaso-moro mentioned this pull request Apr 2, 2026

Add support for Issue Dependencies REST API #4129

Closed

tommaso-moro marked this pull request as ready for review April 2, 2026 14:46

chore: trigger CI

f57a237

gmlewis approved these changes Apr 2, 2026

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 2, 2026

Not-Dhananjay-Mishra reviewed Apr 3, 2026

View reviewed changes

Comment thread github/issues_dependencies.go Outdated

Comment thread github/issues_dependencies.go Outdated

Comment thread github/issues_dependencies.go Outdated

tommaso-moro and others added 4 commits April 3, 2026 11:49

remove omitempty for required param

76cfab3

pass by value instead of reference as param is required

4550de5

add missing fields to Issue struct

13f260e

Merge branch 'master' into tommy/issue-dependencies-support

14b279b

tommaso-moro requested review from Not-Dhananjay-Mishra and gmlewis April 8, 2026 09:11

munlicode approved these changes Apr 8, 2026

View reviewed changes

alexandear reviewed Apr 8, 2026

View reviewed changes

Comment thread github/issues.go Outdated

alexandear suggested changes Apr 8, 2026

View reviewed changes

tommaso-moro and others added 10 commits April 9, 2026 10:11

use any instead of interface{}

6fd4bfd

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Use int64 instead of *int64 for IssueID

171deba

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Update number param to issueNumber for consistency, in github/issues_…

c5e05bf

…dependencies.go Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

Update number param to issueNumber in github/issues_dependencies.go

1d84d92

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>

update number param to issueNumber

a3c6983

fix tests now that IssueID is of type int64

45fb09c

update number param to issueNumber

1e86822

Use int64 for issueNumber parameter

0000b64

Per review feedback: both issue_id and issue_number are integer in the OpenAPI spec, so issueNumber should be int64 for consistency.

clean up test

d261d4f

Merge branch 'master' into tommy/issue-dependencies-support

f4e9158

tommaso-moro commented Apr 24, 2026

View reviewed changes

Comment thread github/gen-stringify-test.go Outdated

tommaso-moro requested review from Not-Dhananjay-Mishra and alexandear April 24, 2026 15:07

Merge branch 'master' into tommy/issue-dependencies-support

dfd8467

gmlewis removed the waiting for reply label Apr 24, 2026

gmlewis requested changes Apr 24, 2026

View reviewed changes

gmlewis added waiting for reply DO NOT MERGE Do not merge this PR. labels Apr 30, 2026

Merge remote-tracking branch 'upstream/master' into tommy/issue-depen…

f4492f2

…dencies-support # Conflicts: # github/github-accessors.go # github/github-accessors_test.go # github/issues.go

tommaso-moro requested a review from gmlewis June 19, 2026 16:30

gmlewis removed waiting for reply DO NOT MERGE Do not merge this PR. labels Jun 19, 2026

gmlewis requested changes Jun 22, 2026

View reviewed changes

Comment thread github/issues_dependencies.go Outdated

Comment thread github/issues.go

Not-Dhananjay-Mishra reviewed Jun 22, 2026

View reviewed changes

Comment thread github/issues_dependencies_test.go Outdated

gmlewis added DO NOT MERGE Do not merge this PR. waiting for signed CLA labels Jun 22, 2026

Rename issueID param to blockingIssueID in RemoveBlockedBy

d7a57bd

Addresses review feedback that issueNumber and issueID are easy to confuse. blockingIssueID makes it clear which issue is being removed as a blocker.

tommaso-moro force-pushed the tommy/issue-dependencies-support branch from d0ec43f to d7a57bd Compare June 22, 2026 14:54

gmlewis removed DO NOT MERGE Do not merge this PR. waiting for signed CLA labels Jun 22, 2026

gmlewis approved these changes Jun 22, 2026

View reviewed changes

Not-Dhananjay-Mishra approved these changes Jun 22, 2026

View reviewed changes

Merge branch 'master' into tommy/issue-dependencies-support

0b1ed3a

alexandear approved these changes Jun 22, 2026

View reviewed changes

gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 22, 2026

gmlewis merged commit 728cdb1 into google:master Jun 22, 2026
14 checks passed

Conversation

tommaso-moro commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Issue Dependencies API support

Changes

Testing

Uh oh!

google-cla Bot commented Apr 2, 2026

Uh oh!

codecov Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaso-moro commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

tommaso-moro commented Jun 19, 2026

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmlewis commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis commented Jun 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tommaso-moro commented Apr 2, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited

Loading

gmlewis commented Jun 22, 2026 •

edited

Loading