Skip to content

Indexer: Minor output formatting update #14055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 24, 2025
Merged

Indexer: Minor output formatting update #14055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions infra/indexer/index/in_memory_index.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ void MaybePrintLinkerMessage(absl::Span<const Entity> entities,
// Secondly, if we have an incomplete entity that does not have a
// corresponding complete entity, then linking will be incomplete.
if (complete_count > 1 && incomplete_count) {
stream << "error: multiple definitions for " << entities[0].name_prefix()
<< entities[0].name() << entities[0].name_suffix() << "\n";
stream << "error: multiple definitions for " << entities[0].full_name()
<< "\n";
} else if (!complete_count && incomplete_count) {
#ifndef NDEBUG
// TODO: Enable this in opt builds once the number of warnings is
// more reasonable.
stream << "warning: no definition found for " << entities[0].name_prefix()
<< entities[0].name() << entities[0].name_suffix() << "\n";
stream << "warning: no definition found for " << entities[0].full_name()
<< "\n";
#else
return;
#endif // NDEBUG
Expand All @@ -91,7 +91,7 @@ void MaybePrintLinkerMessage(absl::Span<const Entity> entities,

for (const auto& entity : entities) {
const auto& location = locations[entity.location_id()];
stream << " " << location.path() << ":" << location.start_line() << ":"
stream << " " << location.path() << ":" << location.start_line() << "-"
<< location.end_line()
<< (entity.is_incomplete() ? "" : " [definition]")
<< (entity.is_weak() ? " [weak]" : "") << "\n";
Expand Down
Loading