Merged
Conversation
oliverchang
reviewed
Oct 21, 2025
| # 165x tests to succeed and some tests skipped. I suspect the skipping causes | ||
| # rake to return an error code. However, in normal circumastances we see | ||
| # 9 tests skipped. | ||
| grep "OK: 165" /tmp/test.out |
Collaborator
There was a problem hiding this comment.
can we make this more robust against changing test numbers?
e.g. look for presence of 0 failures instead?
Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: David Korczynski <david@adalogics.com>
oliverchang
approved these changes
Oct 22, 2025
| # I suspect the skipping causes | ||
| # rake to return an error code. However, in normal circumastances we see | ||
| # 9 tests skipped. | ||
| grep "OK: 165" /tmp/test.out |
Collaborator
There was a problem hiding this comment.
do we still need these OK: checks given the below inverted checks?
Collaborator
Author
There was a problem hiding this comment.
They don't hurt. I'd say yeah let's keep. If for some reason the build would switch to not run any tests at all, then a positive check would catch it but not a negative check.
Collaborator
There was a problem hiding this comment.
my concern was more around this breaking when the number of tests upstream changes. is there a way we can make this safer in that regard?
Signed-off-by: David Korczynski <david@adalogics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.