prometheus: update to native go fuzzing#14183
Merged
AdamKorcz merged 1 commit intogoogle:masterfrom Mar 3, 2026
Merged
Conversation
|
roidelapluie has previously contributed to projects/prometheus. The previous PR was #3908 |
roidelapluie
force-pushed
the
prometheus_native_fuzz
branch
from
b49a476 to
c3f3ab7
Compare
roidelapluie
force-pushed
the
prometheus_native_fuzz
branch
from
b0e6533 to
00abcf6
Compare
roidelapluie
added a commit
to roidelapluie/oss-fuzz
that referenced
this pull request
Jan 13, 2026
The script uses recursive grep to find fuzzer functions, which can match function names in multiple files. This causes fuzzer_filename to contain multiple files, breaking the convertLibFuzzerTestcaseToStdLibGo command during coverage builds. Fix by searching directly for the function signature with testing.F parameter, which only exists in the actual fuzzer test file. This avoids false matches in files that only reference the function name in comments or helper functions. The script now also explicitly fails if multiple matching files are found. Required for google#14183 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
added a commit
to roidelapluie/oss-fuzz
that referenced
this pull request
Jan 13, 2026
The script uses recursive grep to find fuzzer functions, which can match function names in multiple files. This causes fuzzer_filename to contain multiple files, breaking the convertLibFuzzerTestcaseToStdLibGo command during coverage builds. Fix by searching directly for the function signature with testing.F parameter, which only exists in the actual fuzzer test file. This avoids false matches in files that only reference the function name in comments or helper functions. The script now also explicitly fails if multiple matching files are found. Required for google#14183 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
added a commit
to roidelapluie/oss-fuzz
that referenced
this pull request
Jan 13, 2026
The script uses recursive grep to find fuzzer functions, which can match function names in multiple files. This causes fuzzer_filename to contain multiple files, breaking the convertLibFuzzerTestcaseToStdLibGo command during coverage builds. Fix by searching directly for the function signature with testing.F parameter, which only exists in the actual fuzzer test file. This avoids false matches in files that only reference the function name in comments or helper functions. The script now also explicitly fails if multiple matching files are found. Required for google#14183 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
prometheus_native_fuzz
branch
from
00abcf6 to
b49e114
Compare
roidelapluie
added a commit
to roidelapluie/oss-fuzz
that referenced
this pull request
Feb 24, 2026
The script uses recursive grep to find fuzzer functions, which can match function names in multiple files. This causes fuzzer_filename to contain multiple files, breaking the convertLibFuzzerTestcaseToStdLibGo command during coverage builds. Fix by searching directly for the function signature with testing.F parameter, which only exists in the actual fuzzer test file. This avoids false matches in files that only reference the function name in comments or helper functions. The script now also explicitly fails if multiple matching files are found. Required for google#14183 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
AdamKorcz
pushed a commit
that referenced
this pull request
Mar 2, 2026
…14783) The script uses recursive grep to find fuzzer functions, which can match function names in multiple files. This causes fuzzer_filename to contain multiple files, breaking the convertLibFuzzerTestcaseToStdLibGo command during coverage builds. Fix by searching directly for the function signature with testing.F parameter, which only exists in the actual fuzzer test file. This avoids false matches in files that only reference the function name in comments or helper functions. The script now also explicitly fails if multiple matching files are found. Required for #14183 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
prometheus_native_fuzz
branch
2 times, most recently
from
a0e33f9 to
f1b1a2e
Compare
Contributor
Author
|
cc @AdamKorcz Following up Yesterday's pull request, this change is ready to fly 🛫 |
Related to prometheus/prometheus#17393 Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
roidelapluie
force-pushed
the
prometheus_native_fuzz
branch
from
f1b1a2e to
eb1ea69
Compare
Collaborator
|
@roidelapluie has been working with upstream Prometheus. A maintainer approved their work in prometheus/prometheus#17393 (review). |
AdamKorcz
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to prometheus/prometheus#17393