Skip to content

bitcoin: update comment about disable IPC #14203

Merged
DavidKorczynski merged 1 commit intogoogle:masterfrom
fanquake:core_ipc
Oct 30, 2025
Merged

bitcoin: update comment about disable IPC #14203
DavidKorczynski merged 1 commit intogoogle:masterfrom
fanquake:core_ipc

Conversation

@fanquake
Copy link
Copy Markdown
Contributor

@fanquake fanquake commented Oct 29, 2025

The newer images are usable, however re-enabling IPC means working
around capnps internal oss-fuzz detection. So leave it disabled until a
IPC fuzz test exists.

@github-actions
Copy link
Copy Markdown

fanquake (verified) is either the primary contact or is in the CCs list of projects/bitcoin-core.

@fanquake
Copy link
Copy Markdown
Contributor Author

The failure here seems to be that capnp tries to detect if it's being fuzzed, via the LIB_FUZZING_ENGINE environment variable, and if so, enables building additional executables.

@fanquake
Copy link
Copy Markdown
Contributor Author

This was added for it's own oss-fuzz integration: capnproto/capnproto#1188. Best might just be to leave it disabled for now, until we actually having to fuzz something that needs it. Will update our comment here.

The newer images are usable, however re-enabling IPC means working
around capnps internal oss-fuzz detection. So leave it disabled until a
IPC fuzz test exists.
@fanquake fanquake changed the title [WIP] re-enable IPC using Ubuntu 24.04 base image bitcoin: update comment about disable IPC Oct 30, 2025
@fanquake fanquake marked this pull request as ready for review October 30, 2025 11:19
@fanquake
Copy link
Copy Markdown
Contributor Author

cc @maflcko @dergoegge

Copy link
Copy Markdown
Contributor

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidKorczynski DavidKorczynski merged commit 24ba8c5 into google:master Oct 30, 2025
16 checks passed
@fanquake fanquake deleted the core_ipc branch October 30, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants