[avahi] switch to Ubuntu 24.04#14242
Merged
hunsche merged 2 commits intogoogle:masterfrom Dec 10, 2025
Merged
Conversation
|
evverx has previously contributed to projects/avahi. The previous PR was #11564 |
evverx
force-pushed
the
bump
branch
3 times, most recently
from
b7f6743 to
65a4c26
Compare
evverx
force-pushed
the
bump
branch
3 times, most recently
from
7f0b818 to
943b1fa
Compare
Contributor
Author
|
It's waiting for #14382 |
Contributor
Author
|
It fails under MSan (avahi/avahi#787) because of llvm/llvm-project#114377 so I'm going to hold it back for now. |
evverx
added a commit
to evverx/avahi
that referenced
this pull request
Dec 4, 2025
by reusing the homegrown strlcpy function even when glibc comes with strlcpy. On Ubuntu 24.04 glibc comes with strlcpy and it gets picked up and used instead of the homegrown strlcpy function. The issue is that strlcpy isn't intercepted by MSan yet (llvm/llvm-project#114377) so it gets triggered every time strlen is called with strings copied with strlcpy for example. It leads to bogus reports like avahi#787. avahi will switch from Ubuntu 20.04 to Ubuntu 24.04 in google/oss-fuzz#14242.
evverx
added a commit
to avahi/avahi
that referenced
this pull request
Dec 4, 2025
by reusing the homegrown strlcpy function even when glibc comes with strlcpy. On Ubuntu 24.04 glibc comes with strlcpy and it gets picked up and used instead of the homegrown strlcpy function. The issue is that strlcpy isn't intercepted by MSan yet (llvm/llvm-project#114377) so it gets triggered every time strlen is called with strings copied with strlcpy for example. It leads to bogus reports like #787. avahi will switch from Ubuntu 20.04 to Ubuntu 24.04 in google/oss-fuzz#14242.
evverx
force-pushed
the
bump
branch
2 times, most recently
from
03f9fbf to
2094000
Compare
Contributor
Author
|
I got around llvm/llvm-project#114377 with avahi/avahi@f8e6e7c. I think it can be merged. @DavidKorczynski @hunsche can you merge it? |
On Ubuntu 24.04 glibc comes with strlcpy and it isn't intercepted by MSan yet (llvm/llvm-project#114377). avahi/avahi@f8e6e7c was merged to prevent MSan false positives like avahi/avahi#787 from popping up.
hunsche
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Ubuntu 24.04 glibc comes with strlcpy and it isn't intercepted by
MSan yet (llvm/llvm-project#114377).
avahi/avahi@f8e6e7c
was merged to prevent MSan false positives like
avahi/avahi#787 from popping up.