Open
Conversation
Collaborator
|
@arthurscchan can you help review this? |
Contributor
|
LGTM. |
arthurscchan
approved these changes
Nov 6, 2025
Contributor
Author
|
I've managed to work around #14151 and this change seems to work fine. Coverage in my project still fails but for what looks like an unrelated reason. |
Contributor
Author
|
Any update? |
Contributor
Author
|
@DavidKorczynski PTAL again, I think the build failure is unrelated (also saw it on other PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version 0.8.7 only supports java 16.
I can't actually test the base images to verify that this works unfortunately, due to #14151