Open
Conversation
|
xingyaner is a new contributor to projects/checkstyle. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, arthurscchan |
xingyaner
force-pushed
the
fix-checkstyle
branch
from
89fc970 to
90cc270
Compare
DavidKorczynski
requested changes
Jan 22, 2026
Collaborator
DavidKorczynski
left a comment
DavidKorczynski
left a comment
There was a problem hiding this comment.
I don't think we should pin to an old version. Have you validated we can't use the right version in the build? I see jdk 21 references elsewhere:
oss-fuzz/projects/joda-convert/Dockerfile
Line 18 in a7bf195
xingyaner
force-pushed
the
fix-checkstyle
branch
5 times, most recently
from
1187c03 to
991af73
Compare
The Maven build configuration of the Checkstyle project requires Java 21 or a higher version. However, the default OSS-Fuzz base image provides Java 17, resulting in a mismatch error regarding the Java version.
xingyaner
force-pushed
the
fix-checkstyle
branch
from
991af73 to
ced66d8
Compare
Contributor
Author
|
Yes, you are right.Now I have made a new attempt using jdk 21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Checkstyle was migrated to JDK 21, an error was reported because the default build environment used JDK 17 triggered a forced interception by the Maven Enforcer plugin. Even if successful compilation, running environment due to the lack of the JDK 21 can also lead to UnsupportedClassVersionError collapse; The current solution meets the compilation requirements by explicitly switching JAVA_HOME during the build phase, and uses rsync to package the complete JDK 21 runtime environment to the output directory. Combined with the modified wrapper script, the private JDK path and the dynamic library loading path are dynamically specified. The issue of version disconnection between the build and run phases has been resolved.