Skip to content

compile_native_go_fuzzer_v2: fix handling of multiple file matches #14783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamKorcz merged 2 commits into from
Mar 2, 2026
Merged

compile_native_go_fuzzer_v2: fix handling of multiple file matches #14783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5c52fd
compile_native_go_fuzzer_v2: fix handling of multiple file matches
roidelapluie Jan 13, 2026
96c8557
Merge branch 'master' into fix-compile-native-go-fuzzer-v2-multiple-m…
roidelapluie Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions infra/base-images/base-builder/compile_native_go_fuzzer_v2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,25 @@ tags="-tags gofuzz"
# Get absolute path.
abs_file_dir=$(go list $tags -f {{.Dir}} $path)

# TODO(adamkorcz): Get rid of "-r" flag here.
export fuzzer_filename=$(grep -r -l --include='*.go' -s "$function" "${abs_file_dir}")
# Find the file containing the fuzzer function definition.
# Search for the actual function signature with testing.F to avoid false matches
# in files that only reference the function name (e.g., in comments or helper functions).
export fuzzer_filename=$(grep -r -l --include='*.go' "func ${function}(.*testing\.F" "${abs_file_dir}")

# Import build_native_go_fuzzer
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
source "$SCRIPT_DIR/go_utils.sh"

# Test if file contains a line with "func $function" and "testing.F".
if [ $(grep -r "func $function" $fuzzer_filename | grep "testing.F" | wc -l) -eq 1 ]
# Verify we found exactly one file with the fuzzer function.
file_count=$(echo "$fuzzer_filename" | wc -w)
if [ "$file_count" -eq 1 ] && [ -n "$fuzzer_filename" ] && [ -f "$fuzzer_filename" ]
then
build_native_go_fuzzer $fuzzer $function $abs_file_dir $path
elif [ "$file_count" -gt 1 ]
then
echo "Error: Found multiple files with func ${function}(f *testing.F):"
echo "$fuzzer_filename"
exit 1
else
echo "Could not find the function: func ${function}(f *testing.F)"
fi
Loading