cifuzz: reject unsafe tar members in GitHub Actions artifacts#15182
Open
0xmrma wants to merge 1 commit intogoogle:masterfrom
Open
cifuzz: reject unsafe tar members in GitHub Actions artifacts#151820xmrma wants to merge 1 commit intogoogle:masterfrom
0xmrma wants to merge 1 commit intogoogle:masterfrom
Conversation
Author
|
Thanks! This PR hardens CIFuzz GitHub Actions artifact extraction by rejecting unsafe TAR members before extraction. It includes:
Validation run locally: python3 -m unittest infra.cifuzz.filestore.github_actions.github_actions_testI’d appreciate workflow approval so CI can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject unsafe TAR members when downloading GitHub Actions artifacts in CIFuzz.
This change adds validation before extracting artifact TAR files and refuses:
..If an unsafe member is found, extraction is aborted and the artifact download fails safely.
Why
GithubActionsFilestore._download_artifact()previously extracted the embedded TAR withextractall(dst_directory)without validating member paths first.That made it possible for a malicious artifact TAR to attempt writes outside the intended extraction directory.
Changes
_is_safe_tar_member()_safe_extract_tar()extractall()with validated extractionFalseand log an error on unsafe TAR contentTests
Added a unit test that builds a TAR containing:
demo_fuzzer../escape.txtThe test verifies that:
Validation
Ran:
Result: all tests passed.