Skip to content

Fix path traversal when extracting zip files#15233

Open
uwezkhan wants to merge 1 commit intogoogle:masterfrom
uwezkhan:zip-extraction
Open

Fix path traversal when extracting zip files#15233
uwezkhan wants to merge 1 commit intogoogle:masterfrom
uwezkhan:zip-extraction

Conversation

@uwezkhan
Copy link
Copy Markdown

This change prevents path traversal when extracting zip files in
download_and_unpack_zip.

Currently zip_file.extractall() is used without validating file paths,
which allows crafted archives with entries like ../../... or absolute
paths to write outside the target directory.

Added a small helper to validate paths before extraction and return
an error if an unsafe entry is found.

Also added tests to cover normal extraction, path traversal, and
absolute path cases.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 28, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant