feat: create a generic wrapper for gRPC and REST pure background thre…#16154
feat: create a generic wrapper for gRPC and REST pure background thre…#16154bajajneha27 wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the background thread creation logic by introducing a generic template class, AutomaticallyCreatedBackgroundThreadsImpl, to consolidate duplicate code from both gRPC and REST background thread implementations. However, the reviewer identified a critical issue where this generic implementation breaks REST pure background threads due to invalid default-construction of RestPureCompletionQueue and the omission of internal::CallContext setup. To resolve this, the reviewer suggested introducing a customizable QueueTraits template parameter to handle queue-specific initialization and execution logic.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16154 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 2265 2265
Lines 209121 209134 +13
=======================================
+ Hits 192834 192849 +15
+ Misses 16287 16285 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
If this file is now empty, let's delete it.
There was a problem hiding this comment.
If this file is now empty, let's delete it.
…ad impl