fix(storage): resolve transport and retry issues#8235
Open
thiyaguk09 wants to merge 53 commits into
Open
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors request handling and retry logic by transitioning from the common Service class to a specialized StorageTransport. Key changes include the introduction of granular idempotency logic for HTTP methods, improved encryption header management, and a custom parameter serializer. Review feedback identifies a high-severity race condition involving shared interceptors on the Gaxios instance and inconsistent return types in the response handler. Additionally, improvements were suggested regarding the efficiency of JSON parsing within retry loops and the safety of non-null assertions in encryption headers.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
4 tasks
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
011f5b5 to
1ae557f
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
1ae557f to
cc411a0
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
cc411a0 to
9010041
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
9010041 to
0e8f067
Compare
…transport-retry-fix
…request interception and test bench integration
4 tasks
…e etag check - Updated `responseHandler` to correctly handle different payload types: - Plain objects are mutated with `.headers` and `.status` and returned. - Binary payloads (Buffer/Stream) return raw data to prevent dangerous mutations. - Primitives (e.g., empty strings) return the full `GaxiosResponse` wrapper to preserve access to headers like `Location` for resumable upload initiation. - Fixed `hasPrecondition` logic to safely parse stringified JSON or inspect objects directly for an `etag` property. This prevents false positives on raw text payloads containing the word "etag" and false negatives on object payloads.
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
fe44861 to
0a4f5ac
Compare
…transport-retry-fix
Dhriti07
reviewed
May 27, 2026
…replace hardcoded strings in File class
Dhriti07
reviewed
May 27, 2026
Dhriti07
reviewed
May 27, 2026
…ing linting suppressions to ServiceObject
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
0a4f5ac to
e3288e3
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
e3288e3 to
1fba172
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
1fba172 to
d4b912f
Compare
…transport-retry-fix
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
d4b912f to
c0a6220
Compare
…transport-retry-fix
thiyaguk09
force-pushed
the
storage-node-18
branch
from
c0a6220 to
0f2652b
Compare
…transport-retry-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕