Fix: Add missing log domain#3041
Open
qha wants to merge 3 commits into
Open
Conversation
This commit deals with files that actually use log functions in glib.
This commit deals with most files that don't use log functions in glib (yet).
This commit deals with main which doesn't use any log functions in glib and may not be intended to ever do so.
greenbonebot
enabled auto-merge (rebase)
July 16, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add missing log domain.
Why
Files that call logging functions but have not set log domain seem to cause log messages that are not affected by preexisting headings in gvmd_log.conf.
Split into three commits as perhaps you'd prefer not to have it set in files that don't call any logging functions (yet) or main.
I did not set log domain in the _tests.c files as none of them have it, please let me know if you want it there too.
References