Merged
Conversation
signing can return `PTLS_ERROR_ASYNC_OPERATION` which will set the TLS state to `PTLS_STATE_SERVER_GENERATING_CERTIFICATE_VERIFY` It is up to the contract between the crypto implementation/application to notify and retry `ptls_handshake`
in the case of asynchronous operation we are waiting on data, a new buffer cannot be re-used
This reverts commit 5fd2318.
"The data pointed to by args and of size size will be copied and then passed as an argument to func when the job starts" https://www.openssl.org/docs/man1.1.1/man3/ASYNC_start_job.html
when set the callback is called in `ptls_free`
proceed as normal if openssl async is not available
[async signing] no cancellation
Co-authored-by: Emmanuel Thompson <eet6646@gmail.com>
Closed
This was referenced Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #408 with some minor tweaks:
asyncflag is set, synchronous operation is required when running as clientcancel_cband context into one object