Fix spurious ( ) in CORE_EXTRA_LIBS_DIRS when brotli is found#587
Merged
kazuho merged 1 commit intoh2o:masterfrom Mar 15, 2026
Merged
Fix spurious ( ) in CORE_EXTRA_LIBS_DIRS when brotli is found#587kazuho merged 1 commit intoh2o:masterfrom
kazuho merged 1 commit intoh2o:masterfrom
Conversation
LIST(APPEND ...) treats ( and ) as literal list elements, not grouping
syntax. When libbrotlidec/libbrotlienc are found via pkg-config,
CORE_EXTRA_LIBS_DIRS ends up containing bare "(" and ")" which are then
passed to TARGET_LINK_DIRECTORIES, causing a CMake configure error.
Test plan: reproduced via moxygen's standalone build, which pulls
picoquic (and transitively picotls) via CMake FetchContent. In that
layout picotls source lives inside the build tree, so the relative
path "(" resolves to a build-prefixed path and CMake raises a hard
error. Installing libbrotli-dev/brotli triggers the bug; this fix
resolves it.
afrind
referenced
this pull request
in private-octopus/picoquic
Mar 13, 2026
Add a picoquic::picoquic-core alias and include picoquic-core and picotls libraries in an installed CMake export set. This allows parent projects that embed picoquic via FetchContent to link against the namespaced target and re-export it cleanly to their own consumers.
Contributor
Author
|
@kazuho I think this may be needed to compile picoquic + picotls on some systems in certain modes after I made some changes in picoquic. Can you take a look? |
Member
|
Thank you, it did not make sense at all to have parens only here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIST(APPEND ...) treats ( and ) as literal list elements, not grouping syntax. When libbrotlidec/libbrotlienc are found via pkg-config, CORE_EXTRA_LIBS_DIRS ends up containing bare "(" and ")" which are then passed to TARGET_LINK_DIRECTORIES, causing a CMake configure error.
Test plan: reproduced via moxygen's standalone build, which pulls picoquic (and transitively picotls) via CMake FetchContent. In that layout picotls source lives inside the build tree, so the relative path "(" resolves to a build-prefixed path and CMake raises a hard error. Installing libbrotli-dev/brotli triggers the bug; this fix resolves it.
I thought about making a CI here for picotls, but it would have been rather involved.